Merge release/dev17.2 to release/dev17.3#64835
Merged
JoeRobich merged 7 commits intorelease/dev17.3from Oct 19, 2022
Merged
Conversation
Move parts of official build onto new vm images
…s-deps-to-release/dev17.0-vs-deps
…-to-release/dev17.0-vs-deps Merge release/dev16.11-vs-deps to release/dev17.0-vs-deps
…to-release/dev17.2 Merge release/dev17.0-vs-deps to release/dev17.2
Member
|
@JoeRobich why are we merging on red here? |
Member
|
The red CI is from a rolling build of 17.2 which is failing because an arcade update moved us to a new SDK. Arcade updates come in on the 17.0-vs-deps branch which does not run MSBuildWorkspace unit tests. 17.2 does and it requires that the NuGet version stay matched to what shipped in the pinned SDK. I opened #64840 to resolve this issue. |
Member
|
How does the rolling build show up here? |
Member
|
So the GitHub merge bot creates a merge branch with the SHA of the branch that is merging up. Since we are not creating a merge commit by merging the target branch into the merge branch, the rolling runs with matching SHA show up in the PR. Also back-porting this test fix #64849. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from release/dev17.2 into release/dev17.3.
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯
Troubleshooting conflicts
Identify authors of changes which introduced merge conflicts
Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:
Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.
Resolve merge conflicts using your local repo
Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.
git fetch --all git checkout -t upstream/merges/release/dev17.2-to-release/dev17.3 git reset --hard upstream/release/dev17.3 git merge upstream/release/dev17.2 # Fix merge conflicts git commit git push upstream merges/release/dev17.2-to-release/dev17.3 --force